-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BDES-137][bpk-component-mobile-scroll-container] Removed edge fade #3275
[BDES-137][bpk-component-mobile-scroll-container] Removed edge fade #3275
Conversation
Visit https://backpack.github.io/storybook-prs/3275 to see this build running in a browser. |
ab091bd
to
41adbee
Compare
Visit https://backpack.github.io/storybook-prs/3275 to see this build running in a browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you ensure the PR title includes
[JIRA Number][Component updated] as per the first item in the checklist
41adbee
to
de8941d
Compare
Visit https://backpack.github.io/storybook-prs/3275 to see this build running in a browser. |
7a10427
to
de8941d
Compare
de8941d
to
f8b5035
Compare
Visit https://backpack.github.io/storybook-prs/3275 to see this build running in a browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Removed the leading and training indicators as default behavior. Users can still pass
leadingIndicatorClassName
andtrailingIndicatorClassName
to add it back in.Remember to include the following changes:
[KOA-123][BpkButton] Updating the colour
README.md
(If you have created a new component)README.md
.d.ts
) files updated