Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BDES-137][bpk-component-mobile-scroll-container] Removed edge fade #3275

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

FireRedNinja
Copy link
Contributor

@FireRedNinja FireRedNinja commented Mar 11, 2024

Removed the leading and training indicators as default behavior. Users can still pass leadingIndicatorClassName and trailingIndicatorClassName to add it back in.

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • Type declaration (.d.ts) files updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

Copy link

github-actions bot commented Mar 11, 2024

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against f8b5035

Copy link

Visit https://backpack.github.io/storybook-prs/3275 to see this build running in a browser.

@Iain530 Iain530 mentioned this pull request Mar 12, 2024
6 tasks
@FireRedNinja FireRedNinja marked this pull request as ready for review March 13, 2024 09:59
@FireRedNinja FireRedNinja force-pushed the BDES-137-Remove-Fade-BpkMobileScrollContainer branch from ab091bd to 41adbee Compare March 13, 2024 10:00
Copy link

Visit https://backpack.github.io/storybook-prs/3275 to see this build running in a browser.

@FireRedNinja FireRedNinja added major Breaking change minor Non breaking change labels Mar 13, 2024
Copy link
Member

@olliecurtis olliecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you ensure the PR title includes

[JIRA Number][Component updated] as per the first item in the checklist

@FireRedNinja FireRedNinja changed the title [BDES-137] Removed fade from BpkMobileScrollContainer [BDES-137][BpkMobileScrollContainer] Removed fade from BpkMobileScrollContainer Mar 18, 2024
@FireRedNinja FireRedNinja changed the title [BDES-137][BpkMobileScrollContainer] Removed fade from BpkMobileScrollContainer [BDES-137][BpkMobileScrollContainer] Removed edge fade Mar 18, 2024
@FireRedNinja FireRedNinja changed the title [BDES-137][BpkMobileScrollContainer] Removed edge fade [BDES-137][bpk-component-mobile-scroll-container] Removed edge fade Mar 18, 2024
@FireRedNinja FireRedNinja removed the major Breaking change label Mar 20, 2024
@FireRedNinja FireRedNinja force-pushed the BDES-137-Remove-Fade-BpkMobileScrollContainer branch from 41adbee to de8941d Compare April 3, 2024 12:35
Copy link

github-actions bot commented Apr 3, 2024

Visit https://backpack.github.io/storybook-prs/3275 to see this build running in a browser.

@FireRedNinja FireRedNinja force-pushed the BDES-137-Remove-Fade-BpkMobileScrollContainer branch from 7a10427 to de8941d Compare April 15, 2024 10:48
@FireRedNinja FireRedNinja force-pushed the BDES-137-Remove-Fade-BpkMobileScrollContainer branch from de8941d to f8b5035 Compare April 15, 2024 10:48
Copy link

Visit https://backpack.github.io/storybook-prs/3275 to see this build running in a browser.

Copy link
Contributor

@mungodewar mungodewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olliecurtis olliecurtis merged commit 4fa5987 into main Apr 22, 2024
9 checks passed
@olliecurtis olliecurtis deleted the BDES-137-Remove-Fade-BpkMobileScrollContainer branch April 22, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Non breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants