Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO JIRA] Fix dialog types #2930

Merged
merged 1 commit into from
Jul 24, 2023
Merged

[NO JIRA] Fix dialog types #2930

merged 1 commit into from
Jul 24, 2023

Conversation

anambl
Copy link
Contributor

@anambl anambl commented Jul 24, 2023

Remember to include the following changes:

  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@anambl anambl added the patch Patch production bug label Jul 24, 2023
@github-actions
Copy link

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 1e770a8

@github-actions
Copy link

Visit https://backpack.github.io/storybook-prs/2930 to see this build running in a browser.

@anambl anambl merged commit 9727178 into main Jul 24, 2023
8 checks passed
@anambl anambl deleted the no-jira-fix-dialog-types branch July 24, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch production bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants