Koa 5884 migrating packages #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olliecurtis
force-pushed
the
KOA-5884-migrating-packages
branch
4 times, most recently
from
fb56fec
to
6289fd9
Compare
anambl
reviewed
Jul 18, 2023
| @@ -16,7 +16,7 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| @import '~bpk-mixins/index.scss'; | |||
| @import '../../packages/bpk-mixins/index.scss'; | |||
There was a problem hiding this comment.
I guess all of these imports were automatically updated by the code editor? 😄
olliecurtis
force-pushed
the
KOA-5884-migrating-packages
branch
from
c23e5d6
to
aced684
Compare
olliecurtis
force-pushed
the
KOA-5884-migrating-packages
branch
from
f979901
to
8b03f04
Compare
|
Visit https://backpack.github.io/storybook-prs/2908 to see this build running in a browser. |
olliecurtis
force-pushed
the
KOA-5884-migrating-packages
branch
from
8ead54b
to
702c881
Compare
olliecurtis
force-pushed
the
KOA-5884-migrating-packages
branch
from
702c881
to
e475242
Compare
|
Visit https://backpack.github.io/storybook-prs/2908 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/2908 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/2908 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/2908 to see this build running in a browser. |
anambl
reviewed
Jul 28, 2023
.gitignore
Outdated
| /dist-storybook | ||
| /dist-sassdoc |
|
Visit https://backpack.github.io/storybook-prs/2908 to see this build running in a browser. |
olliecurtis
added a commit
that referenced
this pull request
Jul 31, 2023
This reverts commit 7156ceb.
olliecurtis
added a commit
that referenced
this pull request
Jul 31, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating
bpk-mixinsandbpk-stylesheetsto Backpack WebThe benefit of doing so are:
For Backpack itself
@skyscanner/backpack-webandbpk-mixins, and evenbpk-stylesheetsexist together so benefits to consuming projects tooFor consumers
@skyscanner/backpack-web, instead of having to install separately and the risk of having a version defined of mixins/stylesheets whilst Backpack web had older versions defined.Remember to include the following changes:
README.md(If you have created a new component)README.md