[KOA-5703]: Bump css-loader and postcss-loader #2901
Conversation
|
Visit https://backpack.github.io/storybook-prs/2901 to see this build running in a browser. |
olliecurtis
force-pushed
the
KOA-5703-bump-loaders
branch
from
66a9c6b
to
31d2f96
Compare
|
Visit https://backpack.github.io/storybook-prs/2901 to see this build running in a browser. |
olliecurtis
force-pushed
the
KOA-5703-bump-loaders
branch
from
31d2f96
to
5fe3462
Compare
|
Visit https://backpack.github.io/storybook-prs/2901 to see this build running in a browser. |
olliecurtis
force-pushed
the
KOA-5703-bump-loaders
branch
from
5fe3462
to
354ce0d
Compare
|
Visit https://backpack.github.io/storybook-prs/2901 to see this build running in a browser. |
| @@ -23,9 +23,8 @@ const sassFunctions = require('bpk-mixins/sass-functions'); | |||
|
|
|||
| const postCssPlugins = require('../scripts/webpack/postCssPlugins'); | |||
|
|
|||
| const { BPK_TOKENS, ENABLE_CSS_MODULES } = process.env; | |||
There was a problem hiding this comment.
What was the purpose of ENABLE_CSS_MODULES var?
There was a problem hiding this comment.
It looks to be super old configuration which going through our docs and setup we never actually use anywhere so looks to be an irrelevant variable.
It also doesn't line up and work with the configuration we need to provide in the newer css-loader so that we can specify our localIndentName as it would either be a boolean or an object, which we always need to provide the localIndentName, modules would always need to be an object :)
Hope that helps, let me know if not
Bumps the following dependencies:
css-loaderpostcss-loaderMakes required changes to webpack config for storybook to align with latest changes.
Remember to include the following changes:
README.md(If you have created a new component)README.md