LOOM-1367 BpkList Class 2 Overrides (#3377)

.eslintrc

@@ -138,6 +138,7 @@
               "Prop {{prop}} is forbidden. See https://github.com/Skyscanner/eslint-plugin-rules?tab=readme-ov-file#forbid-component-props",
             "allowedFor": [
               "InnerContainer", // allowed for a prop that is passed down in the BpkMobileScrollContainer to a generated element
+              "ListElements",  // allowed for a prop that is passed down in BpkList to the conditional list elements
               "ScrimBpkModalInner", // allowed for a prop that is passed in BpkModal down to a scrim wrapped BpkModalInner component.
               "Slider" // allowed for a prop that is passed in BpkSlider down to the react-slider component.
             ]

packages/bpk-component-list/src/BpkList.js

@@ -40,20 +40,18 @@ const BpkList = (props: Props) => {
   const { ariaLabel, ariaLabelledby, children, className, ordered, title } =
     props;
 
-  const TagName: any = ordered ? 'ol' : 'ul';
+  const ListElements: any = ordered ? 'ol' : 'ul';
   const classNames: string = getClassName('bpk-list', className);
 
   return (
-    <TagName
+    <ListElements
       aria-label={ariaLabel}
       aria-labelledby={ariaLabelledby}
       title={title}
-      // TODO: className to be removed
-      // eslint-disable-next-line @skyscanner/rules/forbid-component-props
       className={classNames}
     >
       {children}
-    </TagName>
+    </ListElements>
   );
 };