Adding Future Gachas/Future Events to a new tab for EN, KR, and TW ease of access #512
Conversation
|
Still running some tests, so please don't merge it yet, theres something with futureevent that I'm trying to debug right now |
src/pages/App.tsx
Outdated
| icon: <MoveToInboxIcon></MoveToInboxIcon>, | ||
| text: t("common:futuregacha"), | ||
| to: "/futuregacha", | ||
| }, |
There was a problem hiding this comment.
Prefer the future variants in a single menu item with children, I can do it after merge if you want
package-lock.json
Outdated
| settings: { isShowSpoiler, region }, | ||
| } = useRootStore(); | ||
|
|
||
| function useCachedData<T extends IEventInfo>( |
There was a problem hiding this comment.
do not extend here, extend the function in utils/index.ts
|
|
||
| function useCachedData<T extends IEventInfo>( | ||
| name: string, | ||
| useRegion: ServerRegion = region |
There was a problem hiding this comment.
In React, use is considered as a reversed keyword for hooks
| "jp" as ServerRegion | ||
| ); | ||
|
|
||
| console.log("b"); |
src/pages/App.tsx
Outdated
| @@ -434,12 +437,24 @@ const DrawerContent: React.FC<{ | |||
| text: t("common:music"), | |||
| to: "/music", | |||
| }, | |||
| { | |||
| { | ||
| disabled: false, | ||
| icon: <MoveToInboxIcon></MoveToInboxIcon>, | ||
| text: t("common:gacha"), | ||
| to: "/gacha", | ||
| }, | ||
| { |
| icon: <CalendarText></CalendarText>, | ||
| text: t("common:futureevent"), | ||
| to: "/futureevent", | ||
| }, |
There was a problem hiding this comment.
Prefer the future variants in a single menu item with children, I can do it after merge if you want
| setEvents([]); | ||
| setPage(0); | ||
| // needed otherwise lint starts complaining that updateSortBy is there and isnt there at the same time | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
removed and it is fine for me
|
|
||
| return ( | ||
| // kinda a brute forced way of doing it tbh, but I just removed the path and set it to send to gacha | ||
| <Link to={"gacha/" + data.id} style={{ textDecoration: "none" }}> |
There was a problem hiding this comment.
Link won't work well because most of the future gachas exist only in JP
There was a problem hiding this comment.
I will consider add region to path params, or can be forced as a query param
There was a problem hiding this comment.
Alrighty, I saw that problem with the events when I was testing, I could try and make a futureGacha page as well where it gets the jp events with similar logic to the other functions?
There was a problem hiding this comment.
Alrighty, I saw that problem with the events when I was testing, I could try and make a futureGacha page as well where it gets the jp events with similar logic to the other functions?
That's not necessary
| (e) => e.startAt >= new Date().getTime() - 31556952000 | ||
| ); | ||
| } | ||
| if (!isShowSpoiler) { |
There was a problem hiding this comment.
By this you mean setting sorted cache to just being an empty array and then breaking?
There was a problem hiding this comment.
if isShowSpoiler is false, it means no spoiler should be shown, so it is meaningless to have if (!isShowSpoiler) branch here, or I misunderstood it
| let sortedCache = [...eventsCache]; | ||
| if (isShowSpoiler) { | ||
| sortedCache = sortedCache.filter( | ||
| (e) => e.startAt >= new Date().getTime() - 31556952000 |
There was a problem hiding this comment.
Oh, I think I explained it in a past push and then deleted it, its a year worth of milliseconds
It would be better to compare against the latest running event/gacha
| (e) => e.startAt >= new Date().getTime() - 31556952000 | ||
| ); | ||
| } | ||
| if (!isShowSpoiler) { |
There was a problem hiding this comment.
if isShowSpoiler is false, it means no spoiler should be shown, so it is meaningless to have if (!isShowSpoiler) branch here, or I misunderstood it
Description
Creating two new pages, one called Future Gacha, one called Future Event. These show events and gachas, starting from one year ago today on JP, in ascending order, only if spoiler tag is enabled. If the tag is not, it will show events on jp from ascending order (I didn't know what to do in this case, if any maintainer would have any other preferences as to what it should start at, I'd be willing to edit it.)
Related Issue
Adding Future Gacha/Future Event
Motivation and Context
Ease of access, we're three years into this game at this point, scrolling through all of the gachas and events to find out when a lim is getting reran or when an event you've been saving for will come back is extremely tedious, this is simply for ease of access.
How Has This Been Tested?
Screenshots (if appropriate):