Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(music): original music video link #487

Merged

Conversation

dnaroma
Copy link
Contributor

@dnaroma dnaroma commented Apr 6, 2024

Description

Project Sekai have now "Original" indicator for songs with original video.

Related Issue

#475

Motivation and Context

Use information from musicOriginals.json to display embedded original music video (youtube and niconico).

How Has This Been Tested?

  • Chrome (Desktop)
  • Chrome (Mobile)
  • Firefox (Desktop)
  • Firefox (Mobile)
  • Safari (Desktop, optional)
  • Safari (iPhone, optional)
  • Safari (iPad, optional)

Screenshots (if appropriate):

image

@dnaroma dnaroma merged commit 627432d into dev Apr 6, 2024
1 check passed
@dnaroma dnaroma deleted the feature/475-add-artist-info-and-video-link-to-music-list branch April 6, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant