Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 sorting cards by id and release date for tw, kr region #457

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

candela97
Copy link
Contributor

Description

Fix sorting cards by id and release date for tw, kr region.

Related Issue

N/A

Motivation and Context

Sorting by id was broken on tw, and sorting by release date was broken on kr.

How Has This Been Tested?

  • Chrome (Desktop)
  • Chrome (Mobile)
  • Firefox (Desktop)
  • Firefox (Mobile)
  • Safari (Desktop, optional)
  • Safari (iPhone, optional)
  • Safari (iPad, optional)

Screenshots (if appropriate):

@dnaroma dnaroma merged commit 684b840 into Sekai-World:dev Oct 29, 2023
1 check passed
@candela97
Copy link
Contributor Author

@dnaroma Seems like none of my PRs actually made it into production 😅

@dnaroma
Copy link
Contributor

dnaroma commented Oct 29, 2023

@dnaroma Seems like none of my PRs actually made it into production 😅

Really, I will check the Tag hash

@dnaroma
Copy link
Contributor

dnaroma commented Oct 29, 2023

I released 1.8.1, the 1.8.0 tag does not work properly

@candela97 candela97 deleted the fix-card-sort-by-id branch October 30, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants