-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: trigger build with latest Lux #882
base: master
Are you sure you want to change the base?
Conversation
361e8ec
to
0c724f7
Compare
@ChrisRackauckas I tracked down and fixed the upstream issues. The only one remaining is https://github.com/SciML/NeuralPDE.jl/actions/runs/10485955321/job/29043159135?pr=882#step:6:1216 but that is kind of hard to handle -- it is matrix multiply with non-concrete element types. Might be best to get the |
I can look into it. Can you open an issue about it? Also, in CI, why is precompilation failing - https://github.com/SciML/NeuralPDE.jl/actions/runs/10485955321/job/29043160310?pr=882#step:6:982 |
Depwarn errors are on, and currently Enzyme doesn't support the latest GPUCompiler which doesn't have those depwarns (same as SciML/DeepEquilibriumNetworks.jl#159) |
That's the right thing to do. |
@wsmoses what should we do about the GPUCompiler Enzyme depwarn issue? How close is that to getting the release? |
Enzyme released a version with the latest gpucompiler last night |
@avik-pal you're unblocked here? |
No I need #883 to be fixed, else it tries to propagate |
Okay, but at least unblocked from non-NeuralPDE things 😅 . @KirillZubov do you think you can have a look at that? |
@ChrisRackauckas ok, I will try figure out with it , it's a little related to my current task |
This reverts commit 71c7071.
src/discretize.jl
Outdated
@@ -217,20 +217,20 @@ function generate_training_sets(domains, dx, eqs, bcs, eltypeθ, dict_indvars::D | |||
|
|||
bcs_train_sets = map(bound_args) do bt | |||
span = map(b -> get(dict_var_span, b, b), bt) | |||
_set = adapt(eltypeθ, | |||
_set = adapt(Array{eltypeθ}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not force an Array
type, since that won't work in most scenarios. Just add a post-adapt convert.(eltypeθ, x)
No description provided.