[WebApp] Add notifications preference block to the profile page, UI part #1117
+134
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rners01
force-pushed
the
add-notifications-preference-to-the-profile-page
branch
from
fa825c8
to
b2f57db
Compare
rners01
force-pushed
the
add-notifications-preference-to-the-profile-page
branch
from
b2f57db
to
551dfd5
Compare
vitto-moz
reviewed
Jan 17, 2024
Comment on lines
+54
to
+58
| const opacity = state.isDisabled ? 0.5 : 1 | ||
| const transition = 'opacity 300ms' | ||
| const colorValue = type === 'dark' ? '#DBF1C1' : '#0A2133' | ||
|
|
||
| return { ...provided, opacity, transition, color: colorValue } |
There was a problem hiding this comment.
Suggested change
| const opacity = state.isDisabled ? 0.5 : 1 | |
| const transition = 'opacity 300ms' | |
| const colorValue = type === 'dark' ? '#DBF1C1' : '#0A2133' | |
| return { ...provided, opacity, transition, color: colorValue } | |
| return { | |
| ...provided, | |
| opacity: state.isDisabled ? 0.5 : 1, | |
| transition: 'opacity 300ms', | |
| color: type === 'dark' ? '#DBF1C1' : '#0A2133', | |
| } |
| })} | ||
| options={options} | ||
| onChange={onChange} | ||
| defaultValue={options && options[0]} |
There was a problem hiding this comment.
Suggested change
| defaultValue={options && options[0]} | |
| defaultValue={options?.[0]} |
| defaultValue={options && options[0]} | ||
| styles={customStyles} | ||
| theme={(selectTheme) => ({ | ||
| // TODO: Get the theme data using react-jss |
There was a problem hiding this comment.
Could you, please, explain this comment?
| import { config } from '../../../../config' | ||
| import { withLogin } from '../../../auth-views' | ||
| import type { Avatar, Profile } from '../../../profile/models' | ||
| import { AccountTermsAndConditionsUpdate } from './AccountTermsAndConditionsUpdate' | ||
| import { GoogleSignInForm } from './GoogleSignInForm' | ||
| import { PayPalLoginButton } from './PayPalLoginButton' | ||
| import { accountNotificationPreferenceDropdownOptions } from './assets/constants' | ||
|
|
||
| const styles = (theme: SaladTheme) => ({ |
There was a problem hiding this comment.
let's use CSS.Properties for autocomplete
const styles: (theme: SaladTheme) => Record<string, CSS.Properties> = (theme: SaladTheme) => ({
Comment on lines
+330
to
+343
| <div className={classes.notificationPreference}> | ||
| <div className={classes.fieldContainer}> | ||
| <div className={classes.notificationPrefenceLabel}> | ||
| <Text variant="baseS">Account Activity Notifications</Text> | ||
| </div> | ||
| <Dropdown type="light" options={accountNotificationPreferenceDropdownOptions} /> | ||
| </div> | ||
| <div className={classes.textContainer}> | ||
| <Text variant="baseS"> | ||
| Notifications related to your usage and progress within Salad. e.g.: Achievements, Progress towards | ||
| your Target Reward, etc. | ||
| </Text> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
This component JSX part is pretty large: what do you think about moving this repetitive code to a separate component <NotificationPreference/>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: UI part without connection
https://www.notion.so/saladtech/Frontend-Webapp-Notification-Controls-c9f82541d2964290b2f352d9b6af569a