added check-manifest pre-commit hook #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #99 +/- ##
=======================================
Coverage 39.94% 39.94%
=======================================
Files 12 12
Lines 691 691
=======================================
Hits 276 276
Misses 415 415 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
niksirbi
added a commit
that referenced
this pull request
Nov 13, 2023
* added check-manifest pre-commit hook * added no-build-isolation to check-manifest hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check-manifestalways trips me up. It's part of our actions workflow, but not ofpre-commit. This results in me discovering annoying manifest problems only after I push.I think it's worth adding
check-manifestto thepre-commithooks, so we catch the problems at their root.The only downside I can think of is that the pre-commit check will be slightly slower.
Interested to hear your thoughts on this.