Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test helper pytest fixture. #88

Merged

Conversation

samcunliffe
Copy link
Member

A way to have convenience helper functions for developing tests.

The screenshot function is grabbed from the now-dead #61.

A way to have convenience helper functions for developing tests.
@sfmig prefers a fixture.
https://stackoverflow.com/a/42156088/1444054
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2023

Codecov Report

Merging #88 (041b521) into main (3c67c43) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   29.94%   29.94%           
=======================================
  Files          12       12           
  Lines         688      688           
=======================================
  Hits          206      206           
  Misses        482      482           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@sfmig sfmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just minor comments

tests/test_integration/conftest.py Outdated Show resolved Hide resolved
tests/test_integration/conftest.py Outdated Show resolved Hide resolved
tests/test_integration/conftest.py Outdated Show resolved Hide resolved
samcunliffe and others added 2 commits May 18, 2023 18:00
Co-authored-by: sfmig <33267254+sfmig@users.noreply.github.com>
@samcunliffe samcunliffe requested a review from sfmig May 18, 2023 17:04
@samcunliffe samcunliffe merged commit 7852d8e into main May 18, 2023
@samcunliffe samcunliffe deleted the test-helpers-not-testing-the-helpers-but-helpers-for-tests branch May 18, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants