Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAP-S4HA10-setup-simplemount-sle15.adoc: fix issue #382 #384

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

lpinne
Copy link
Contributor

@lpinne lpinne commented Jul 12, 2023

Hi,

SAP-S4HA10-setup-simplemount-sle15.adoc: fix issue #382

Regards,
Lars

@lpinne lpinne requested a review from chabowski July 12, 2023 10:05
@lpinne
Copy link
Contributor Author

lpinne commented Jul 12, 2023

Hi,

I also added a fix for issue #292

Regards,
Lars

@chabowski
Copy link
Collaborator

Hi @lpinne, the doc is not building, I am getting error messages

asciidoctor: WARNING: skipping reference to missing attribute: my2node3
asciidoctor: WARNING: skipping reference to missing attribute: my2node4

Could you please check that first? Thank you!

@lpinne
Copy link
Contributor Author

lpinne commented Jul 13, 2023

Hi Meike,

I changed my2Node... to my2nd...
Thank your for your patience!

Regards,
Lars

Copy link
Collaborator

@chabowski chabowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lpinne, looks good. Merging and closing.

@chabowski chabowski merged commit 7fb017d into main Jul 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants