Ajout des rues environnantes dans les sms de position - PR pour l'issue #256 #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonjour !
Vu que l'issue #256 était validée et qu'aucune PR n'a été faite depuis, je me suis permis de la faire.
Je me suis basé sur le code de fowlerztwitch que j'ai corrigé/finalisé.
J'ai fait le choix de changer le stockage des coordonnées dans les SMS, en passant par des Vecteur3 au lieu de Vecteur2, afin de permettre la récupération des rues environnantes sans calcul hasardeux de la coordonnée en Z.
La compatibilité avec l'ancien format est assurée pour ne rien casser (ça affiche Destination comme avant).
Je suis évidemment preneur de tout retour.
Le rendu :
