Even more fixes for the saving system #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byte-Nova
added
issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some vanilla functions force an auto-save trigger whenever they are executed from a (supposedly) separate thread than the main one or an Unity co-routine. This causes saving violation exceptions when it's about a function that is saved both by us and the game.
This PR implements a change that completely disables the vanilla auto-saver as long as the player is in multiplayer mode, while keeping our save / auto-save functions still working.
To replicate the issue: Find a vanilla feature that forces a save (in this case giving a name to your faction/settlement whenever the message prompts)
PD: These changes were checked using the 1.5 pre-release of the game, testing with current 1.4 is needed.