Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analysis bar theme setting not working #1022

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Daxanius
Copy link

When customizing the theme for spotify-tui, I noticed I couldn't customize the analysis bar colors.

At first I thought I was doing something wrong, but looking into the source, it looks like you forgot to properly add the setting to the config. This is what I've fixed in this quick fix.

@emilHof
Copy link

emilHof commented Nov 19, 2022

I noticed the same thing! The changes you made are the ones that worked for me locally too! Hope this gets merged soon!

Copy link

@emilHof emilHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes did not produce any test failures, compilation errors, or issues when I implemented them locally!

@Daxanius
Copy link
Author

Daxanius commented Nov 19, 2022

The developer of this project seems to be inactive unfortunately. The rspotify crate (and many others) has also been updated in the meantime.

On top of that, this project still uses OpenSSL 1.1, which is now known to have a major security vulnerability.

I've looked into updating these dependencies myself, but so much seems to have changed that you're looking at potentially rewriting the entire project, unfortunately.

@emilHof
Copy link

emilHof commented Nov 20, 2022

yes, that does kind of go with the current narrative of this app.. they did mention that they were currently too busy to do much of the maintenance work in this issue.

i did have some trouble with getting OpenSSL to work as well, bu was not even aware of the security issues it poses!

At what point is it appropriate to start a fork if a maintainer is not so active? i am quite new to OSS, so there is a lot of etiquette that I am not aware of..

@Daxanius
Copy link
Author

The appropriate time would be whenever you feel like it. It's FOSS, you do what you want with it.

If you're not satisfied with how something is you make a fork and you fix it.

That said, I honestly think it's better to start something like this from scratch, as the issue you linked mentions it desperately needs an infrastructure rewrite.

I recently saw that someone was already making a new Spotify TUI from scratch, but it hasn't progressed much unfortunately.

I myself am looking to either keep this project going, or to make something myself. Either way both paths require work and time.

@emilHof
Copy link

emilHof commented Nov 20, 2022

that makes sense. i would assume the answer to the question of what to do would also depend on possibly getting a group of people together who would be willing to maintain it. i may be wrong in this perception, but starting something new simply to have it fall to the wayside again seems somewhat of a waste...

how silly would it be to try and restructure the existing app and use some of the framework that has already been established, and see where it goes from there?

you are right, i am seeing this too now, the maintainer did mention that spotify-tui would need a major rewrite, yet i am also quite new to this and i am not sure how capable i would be of coming up with something better from scratch..

@Daxanius
Copy link
Author

Yeah...

Restructuring the current project would require you to understand it's code & architecture before making any major changes. This alone can take a long time. On top of that you'd have to throw away a lot of code and move and mess with stuff before having patched together something which works.

I'd say this is silly to the max :)

@emilHof
Copy link

emilHof commented Nov 20, 2022

You are making some very good arguments there.. From what I am putting together, both a rewrite and starting from scratch will take a lot of time. And time is valuable haha! I mean, as long as it somewhat works for now, I am content with it! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants