Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter position ordering (not ignore Position property) #4870

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nesopo
Copy link

@nesopo nesopo commented Apr 26, 2024

Fix parameter position ordering (not ignore Position property) at model. Fix moment import syntax error for typescript version 4.3 (rxJsVersion 7.0)

@@ -36,13 +36,13 @@ public class TypeScriptOperationModel : OperationModelBase<TypeScriptParameterMo
_settings = settings;
_generator = generator;

var parameters = GetActualParameters();
var parameters = GetActualParameters().OrderBy(p => p.Position).ToList();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ToList() calls should be removed from here and below, there's no need to materialize as list as it is done at the end anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants