Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created mod setaotw and removeaotw commands #53

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

zapobyte
Copy link
Contributor

@zapobyte zapobyte commented Jan 21, 2020

created 2 commands for aotw role managment

  • !setaotw @user - if done by a mod user will give the mentioned user aotw role.
  • !removeaotw @user - if done by a mod user will remove aotw winner role from the mentioned user.

To check if the user giving the right role and if he has the right role to perform the actions I have added in the .env config files 2 variables:ROLE_MOD_NAMEand AOTW_ROLE_ID which are used in both commands.
ROLE_MOD_NAME hold the name of the role mod('mod' example)
AOTW_ROLE_ID is the id of the role('667583344573284384' example

@meleu
Copy link
Contributor

meleu commented Jan 22, 2020

Yo, thanks!

It's being a busy week here. Will try to review/test this on the next weekend.

@meleu
Copy link
Contributor

meleu commented Jan 24, 2020

hey @vzapo lemme share with you how the AotW thing works on our discord server.

  • There's a exclusive channel for the AotW winners.
  • Every week the "AotW players" choose an achievement to get during that week.
  • When the AotW changes, the channel must "emptied" (remove aotw-winner role from everyone)
  • As players earn the AotW, they receive the aotw-winner role.

That being said, what I thought to make mods life easier is:

  • a command to set the aotw-winner role to individuals
  • a command to remove the aotw-winner role from everyone.

(in other words, a command to remove the role from individuals would not be that necessary)

@zapobyte
Copy link
Contributor Author

zapobyte commented Jan 24, 2020

ahh i see. might help something like this:

  • create a command to remove all aotw winners roles from all who has it.
  • as an addition i could create a function that would run weekly and auto remove aotw roll from all the users in the channel that had the role. When the week ends the bot will congratulate all the winners of that week also, something like :trophy: Congratulations to all {numbersOfPlayers} AOTW Winners from this week. Good luck to all the coming week.
    also remove the single aotw tag could be still there might be used sometimes doesn't hurt anyone :D

@meleu
Copy link
Contributor

meleu commented Jan 24, 2020

as an addition i could create a function that would run weekly and auto remove aotw roll from all the users in the channel that had the role.

There's no need for this, cause the "AotW renovation" is manually handled by the AotW maintainers (currently @ikki5 and Flara). Although they try to attend a schedule, they also have RL commitments.

Then I prefer to not make RABot do things automatically in a very specific time. It would create a false impression to the players community that the AotW maintainers must meet the RABot's schedule (and, well, we are all volunteers here...).

@zapobyte
Copy link
Contributor Author

Yeah, you're right. I did not think of that, just wanted to help their work a bit :) Thought it would be easier for them not to remove it manually since they have to credit manually.
I'll work on the rest of necessary adjustments then.

@zapobyte
Copy link
Contributor Author

zapobyte commented Jan 27, 2020

Hey guys, think this is ready for review now.
I've ended up with this workflow:

  • !setaotw @user remains the same as before
  • !removeaotw command workflow changed.
    • The command now works with no parameters but also accepts @user mention as first parameter.
    • If there is a @user mentioned in the command the aotw role will be removed only from that user.
    • If there is no mention the bot will prompt a message which will tell you to confirm the remove of role from all users. If the requesting mod answers with yes or y in the next 3 seconds the bot will continue with the removal of role from all users. Upon finish the following message will appear: **${aotwRole.name}** role has been removed from **${aotwUsers}**(this is number of users) users.
    • If there is no confirmation after 3 seconds the command will be cancel.

* not using aliases (I realized it brings more confusion than "user-friendliness")
* giving proper feedback when the command fails
* other cleanups
@meleu
Copy link
Contributor

meleu commented Jan 28, 2020

I've made some changes in the setaotw.js, but now I need to go to bed.

Later I'll review the removeaotw.js

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants