Better on off params

[JosuGZ]

Enabling the BHO feature is confusing, as writing "true" will return state == "on" => false, thus disabling BHO. I was thinking there was a problem with the feature itself.

Having an enum that only takes "on" or "off" should avoid this confusion.

This is also implemented on the "sinc" feature (which I guess is gsync?).

[phush0]

Sync is to sync battery and ac profiles. It is not connected with G-SYNC

[JosuGZ]

Thanks! I didn't knew. I still think it makes more sense to have clap validate that the input is either on or off.

Here is how it looks:

$ razer-cli write bho --help
Set battery health optimization

Usage: razer-cli write bho <STATE> [THRESHOLD]

Arguments:
  <STATE>      [possible values: on, off]
  [THRESHOLD]  charging threshold

Options:
  -h, --help  Print help

$ razer-cli write sync --help
Set sync

Usage: razer-cli write sync <SYNC_STATE>

Arguments:
  <SYNC_STATE>  [possible values: on, off]

Options:
  -h, --help  Print help

[dleviminzi]

Thanks! I didn't knew. I still think it makes more sense to have clap validate that the input is either on or off.

Here is how it looks:

$ razer-cli write bho --help
Set battery health optimization

Usage: razer-cli write bho <STATE> [THRESHOLD]

Arguments:
  <STATE>      [possible values: on, off]
  [THRESHOLD]  charging threshold

Options:
  -h, --help  Print help

$ razer-cli write sync --help
Set sync

Usage: razer-cli write sync <SYNC_STATE>

Arguments:
  <SYNC_STATE>  [possible values: on, off]

Options:
  -h, --help  Print help

This seems like a good idea to me.