Merge pull request #313 from RamiAwar/handle-generate-title-exceptions

feat: Add openai error handling to gen title call
RamiAwar · Sep 1, 2024 · 156ccd1 · 156ccd1
2 parents 03e6310 + 3ada82e
commit 156ccd1
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 14 deletions.
diff --git a/backend/dataline/services/conversation.py b/backend/dataline/services/conversation.py
@@ -4,7 +4,9 @@
 
 from fastapi import Depends
 from langchain_core.messages import AIMessage, BaseMessage, HumanMessage, SystemMessage
+from openai._exceptions import APIError
 
+from dataline.errors import UserFacingError
 from dataline.models.conversation.schema import (
     ConversationOut,
     ConversationWithMessagesWithResultsOut,
@@ -36,7 +38,9 @@
 from dataline.repositories.result import ResultRepository
 from dataline.services.connection import ConnectionService
 from dataline.services.llm_flow.graph import QueryGraphService
-from dataline.services.llm_flow.llm_calls.conversation_title_generator import ConversationTitleGenerator
+from dataline.services.llm_flow.llm_calls.conversation_title_generator import (
+    ConversationTitleGenerator,
+)
 from dataline.services.settings import SettingsService
 from dataline.utils.utils import stream_event_str
 
@@ -73,15 +77,18 @@ async def generate_title(self, session: AsyncSession, conversation_id: UUID) ->
         api_key = user_details.openai_api_key.get_secret_value()
 
         first_message_content = conversation.messages[0].message.content
-        title_generator = ConversationTitleGenerator(
-            first_message=first_message_content, api_key=api_key, base_url=user_details.openai_base_url
-        )
-        title = title_generator.call().choices[0].message.content
-        if not title:
-            return "Untitled chat"
+        try:
+            title_generator = ConversationTitleGenerator(
+                first_message=first_message_content, api_key=api_key, base_url=user_details.openai_base_url
+            )
+            title = title_generator.call().choices[0].message.content
+            if not title:
+                return "Untitled chat"
 
-        updated_conversation = await self.update_conversation_name(session, conversation_id, title)
-        return updated_conversation.name
+            updated_conversation = await self.update_conversation_name(session, conversation_id, title)
+            return updated_conversation.name
+        except APIError as e:
+            raise UserFacingError(e)
 
     async def create_conversation(
         self,

diff --git a/frontend/src/hooks/conversations.ts b/frontend/src/hooks/conversations.ts
@@ -10,6 +10,7 @@ import { getBackendStatusQuery } from "@/hooks/settings";
 import { useEffect } from "react";
 import { useParams } from "@tanstack/react-router";
 import { useGetConnections } from "./connections";
+import { isAxiosError } from "axios";
 
 export const CONVERSATIONS_QUERY_KEY = ["CONVERSATIONS"];
 
@@ -98,11 +99,18 @@ export function useGenerateConversationTitle(options = {}) {
   return useMutation({
     mutationFn: async ({ id }: { id: string }) =>
       (await api.generateConversationTitle(id)).data,
-    onError() {
-      enqueueSnackbar({
-        variant: "error",
-        message: "Error generating conversation title",
-      });
+    onError(error) {
+      if (isAxiosError(error) && error.response?.status === 400) {
+        enqueueSnackbar({
+          variant: "error",
+          message: error.response.data.detail,
+        });
+      } else {
+        enqueueSnackbar({
+          variant: "error",
+          message: "There was a problem generating a conversation title",
+        });
+      }
     },
     onSuccess() {
       queryClient.invalidateQueries({ queryKey: CONVERSATIONS_QUERY_KEY });