Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/line selections #54

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Feature/line selections #54

merged 2 commits into from
Jul 12, 2024

Conversation

EvieePy
Copy link
Member

@EvieePy EvieePy commented Jul 12, 2024

Description

Adds line selections/highlighting.
Clicking on a line in a file will select the line.
Clicking or Shift + Clicking and then Shift + Clicking will select the block.
This is additive when selecting downwards; E.g. it will add to the current block.

Lines can be selected via the URL with the following syntax via query string:
?lines=F[N]-L[N]-L[N]_F[N]-L[N]...

E.g. F1-L10-L15 or F2-L9

Where F[N] is the file number (1 indexed).
And the first L[N] is the starting Line followed by the ending line if there is one.

  • Fixed a bug in the discord token scanner.
  • Fixed some CSS.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

Copy link
Collaborator

@AbstractUmbra AbstractUmbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EvieePy EvieePy merged commit 5896861 into main Jul 12, 2024
3 checks passed
@EvieePy EvieePy deleted the feature/line-selections branch July 12, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants