Gas model #13
Merged
Gas model #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
eldond
commented
Sep 25, 2023
eldond
commented
- Adds a simple model for converting a gas command in V(t) into a flow rate vs. time. Includes slightly nonlinear equilibrium flow(voltage) as well as dead time and first order lag between flow and command.
- The instant gas model that goes from equilibrium flow(voltage) is taken from DIII-D.
- The dynamics model is just FOPDT.
- Model is sensitive to gas species.
- All tuning is made up or copied from DIII-D and not valid for SPARC; these are just sample data that have to be fixed up later.
- Should be adequate for setting up any workflow that needs an actuator model.
- Close Make a simple actuator model for use in testing #6
- Gas model is based on DIII-D valve flow(command) at steady state - Dynamics from First-Order Plus Dead Time - Default tuning is copied from DIII-D or made up - Model is sensitive to gas species - Model should be valid for building workflows using sample data
|
Force push was to rebase and squash all the cleanup/fix commits together. The log must be clean. |
anchal-physics
requested changes
Sep 25, 2023
anchal-physics
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.