Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add work flow protocol #14

Merged
merged 6 commits into from
Jul 4, 2024
Merged

add work flow protocol #14

merged 6 commits into from
Jul 4, 2024

Conversation

MarkTNO
Copy link
Contributor

@MarkTNO MarkTNO commented Jun 18, 2024

No description provided.

@MarkTNO MarkTNO linked an issue Jun 18, 2024 that may be closed by this pull request
Add work flow protocols #13
Closed
@MarkTNO MarkTNO marked this pull request as ready for review June 21, 2024 15:40
lfse-slafleur
lfse-slafleur requested changes Jul 1, 2024
View reviewed changes
Copy link
Member

@lfse-slafleur lfse-slafleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just 1 remark regarding the python version. Approved otherwise.

ci/linux/create_venv.sh Show resolved Hide resolved
@MarkTNO MarkTNO merged commit 2ab4472 into main Jul 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfse-slafleur lfse-slafleur lfse-slafleur approved these changes

@cwang39403 cwang39403 Awaiting requested review from cwang39403

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add work flow protocols
2 participants
@MarkTNO @lfse-slafleur