Skip to content

Commit

Permalink
30: Update dependencies to Python3.12 and update flake8 to solve lint…
Browse files Browse the repository at this point in the history 
…ing false positive.
  • Loading branch information
@lfse-slafleur
lfse-slafleur committed Sep 19, 2024
1 parent c394167 commit d4f0415
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
10 changes: 5 additions & 5 deletions dev-requirements.txt
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.11
# This file is autogenerated by pip-compile with Python 3.12
# by the following command:
#
# pip-compile --constraint=requirements.txt --extra=dev --output-file=dev-requirements.txt pyproject.toml
Expand Down Expand Up @@ -63,7 +63,7 @@ colorama==0.4.6
# omotes-rest (pyproject.toml)
coverage[toml]==7.6.1
# via pytest-cov
flake8==6.0.0
flake8==6.1.0
# via
# flake8-docstrings
# flake8-pyproject
Expand All @@ -73,7 +73,7 @@ flake8-docstrings==1.7.0
# via omotes-rest (pyproject.toml)
flake8-pyproject==1.2.3
# via omotes-rest (pyproject.toml)
flake8-quotes==3.3.2
flake8-quotes==3.4.0
# via omotes-rest (pyproject.toml)
flask==2.3.3
# via
Expand Down Expand Up @@ -200,11 +200,11 @@ psycopg2-binary==2.9.9
# via
# -c requirements.txt
# omotes-rest (pyproject.toml)
pycodestyle==2.10.0
pycodestyle==2.11.1
# via flake8
pydocstyle==6.3.0
# via flake8-docstrings
pyflakes==3.0.1
pyflakes==3.1.0
# via flake8
pyproject-hooks==1.1.0
# via build
Expand Down
8 changes: 4 additions & 4 deletions pyproject.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ dependencies = [
dev = [
#"pip-tools~=6.13.0", # Installed via create_env script
"black ~= 22.1.0",
"flake8 ~= 6.0.0",
"Flake8-pyproject ~= 1.2.3",
"flake8-docstrings ~= 1.7.0",
"flake8-quotes ~= 3.3.2",

This comment has been minimized.

Sign in to view

Copy link
@MarkTNO

MarkTNO Sep 19, 2024

Contributor

Is this precise enough?
For instance I understand correctly that flake8-quotes==3.3.2 does not work but flake8-quotes==3.4.0 does? Then "flake8-quotes ~= 3.3" gives too much freedom?

This comment has been minimized.

Sign in to view

Copy link
@lfse-slafleur

lfse-slafleur Sep 20, 2024

Author Member

@MarkTNO

Ahhh this question got tagged with a specific commit and not with the PR. That is why I missed it.

My reply from the e-mail:
Zie ook pip requirements: https://packaging.python.org/en/latest/specifications/version-specifiers/#compatible-release
Zoals je wss ook weet flake8-quotes ~= 3.3  flake8-quotes >= 3.3.* < 4.0

Flake8 gebruikt semantic versioning https://flake8.pycqa.org/en/latest/internal/releases.html dus restricten op alleen grote releases zou niet een probleem moeten vormen.
De plugins zijn wat minder duidelijk in wat voor versioning strategie ze aanhouden, maar ik veronderstel daar ook een semantic versioning-achtige strategie.

Dus daarmee zouden we flake8 en derivaten veilig moeten kunnen updaten bij elke call van update-dependencies.sh voor minor and patch releases. Mocht het mis gaan, zien we
het gelukkig direct in de CI pijplijn en vangen we het redelijk snel.

Dit was mijn redenatie om hem wat minder strak te zetten. Hoe kijk jij ernaar?
"flake8 ~= 6.0",
"Flake8-pyproject ~= 1.2",
"flake8-docstrings ~= 1.7",
"flake8-quotes ~= 3.3",
"pytest ~= 7.3.1",
"pytest-cov ~= 4.0.0",
"mypy ~= 1.5.1",
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.11
# This file is autogenerated by pip-compile with Python 3.12
# by the following command:
#
# pip-compile --output-file=requirements.txt pyproject.toml
Expand Down

0 comments on commit d4f0415

Please sign in to comment.