add gradients for euler2d #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradients for each app are disabled by default, so to enable them one to have:
defined before including the demoapps headers (e.g. added as a compile definition when building an executable)
NOTE : This is still a draft because I need to think more about whether it is better NOT to put the gradients insdie the app and just keep a separate object for doing so. Effectively there is no strong reason for keeping the gradients inside the app.
The gradients just need a mesh object and field on it, so it is fully orthogonal to what the field is.
The state vector is lives outside anyway, so this is another reason for keeping the gradients separate.