Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sql permalink #3663

Merged
merged 6 commits into from
Feb 3, 2021
Merged

Sql permalink #3663

merged 6 commits into from
Feb 3, 2021

Conversation

Crashillo
Copy link
Member

@Crashillo Crashillo commented Jan 28, 2021

Closes https://github.com/PopulateTools/issues/issues/1150

✌️ What does this PR do?

  • When the user runs a query, immediately the url is updated with such query (encoded)
  • When the url contains sql= parameter, it's parsed into the editor

Test: https://getafe.gobify.net

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #3663 (5d99f02) into master (fc6aefb) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3663   +/-   ##
=======================================
  Coverage   84.17%   84.17%           
=======================================
  Files         805      805           
  Lines       21510    21510           
=======================================
+ Hits        18105    18106    +1     
+ Misses       3405     3404    -1     
Impacted Files Coverage Δ
app/helpers/gobierto_budgets/application_helper.rb 64.58% <0.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc6aefb...ae96973. Read the comment docs.

@Crashillo Crashillo marked this pull request as ready for review January 29, 2021 11:36
Copy link
Member

@ferblape ferblape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm, something is broken, if you load a query URL such as https://getafe.gobify.net/datos/calidad-del-aire/q/160, the SQL query is not loaded in the editor and nothing happens:

Screenshot 2021-02-01 at 07 02 19

Also, if you go to a dataset, play with queries and then click on a saved query it breaks with a JS error

@Crashillo
Copy link
Member Author

Errors fixed and deployed

@furilo
Copy link
Member

furilo commented Feb 3, 2021 via email

@ferblape ferblape merged commit f24348f into master Feb 3, 2021
@ferblape ferblape deleted the 1150-sql-permalink branch February 3, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants