-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sql permalink #3663
Sql permalink #3663
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3663 +/- ##
=======================================
Coverage 84.17% 84.17%
=======================================
Files 805 805
Lines 21510 21510
=======================================
+ Hits 18105 18106 +1
+ Misses 3405 3404 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmmm, something is broken, if you load a query URL such as https://getafe.gobify.net/datos/calidad-del-aire/q/160, the SQL query is not loaded in the editor and nothing happens:
Also, if you go to a dataset, play with queries and then click on a saved query it breaks with a JS error
remove default assignment
Errors fixed and deployed |
It seems OK.
|
Closes https://github.com/PopulateTools/issues/issues/1150
✌️ What does this PR do?
sql=
parameter, it's parsed into the editorTest: https://getafe.gobify.net