Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update machines #1091

Merged
merged 4 commits into from
May 23, 2024
Merged

Update machines #1091

merged 4 commits into from
May 23, 2024

Conversation

edenbynever
Copy link
Contributor

This patch hopefully brings PokeAPI's information regarding machines up to date.

For BDSP, there's only minor variation from Diamond and Pearl, but I went ahead and scripted the process anyway to try to ensure that my first contribution to the project didn't contain any errors.

I couldn't find any information regarding how best to add new items, but I figured it made sense enough to auto-increment from just before the ones with "weird" IDs.

I wanted quite badly to sort machines.csv by generation rather than TM number before updating it, but I settled for just sorting my additions that way, mostly in the interest of localizing the changes, and that in order to preempt the likely discovery of more new machines in Teal Mask.

I'm probably missing something somewhere, but this should get us most of the way toward closing #1029.

This is just to prepare the addition of the Gen IX machines.
These were extracted and converted programmatically, but it seems likely
the source doesn't have complete information judging by the disparity in
apparent availability between *Teal Mask* and *Indigo Disk*.
@Naramsim Naramsim merged commit f464535 into PokeAPI:master May 23, 2024
3 checks passed
@Naramsim
Copy link
Member

Naramsim commented May 23, 2024

Thanks a lot! Contributions are much appreciated!

@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

@edenbynever edenbynever deleted the update-machines branch May 23, 2024 21:55
Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants