Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add totk presets #74

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Add totk presets #74

merged 1 commit into from
Sep 30, 2023

Conversation

savage13
Copy link
Collaborator

Towers, Shrines, Lightroots, Koroks, Caves, Well, Chasms, Bubbulfrogs

Towers, Shrines, Lightroots, Koroks, Caves, Well, Chasms, Bubbulfrogs
@Pistonight
Copy link
Contributor

Thanks for the PR. Just a couple questions:

  1. Where are the referenced icons?
  2. I will probably make some tweaks to it, like extracting the data and using a script to generate the preset files. Would that be fine?

@savage13
Copy link
Collaborator Author

  • I was unsure about the icons.
  • I started building a basic html page to generate the presets, built on javascript and running queries on a database. The major issue is getting the UI Names from the database. I modified the database to output the ui names.

@savage13
Copy link
Collaborator Author

I did the PR directly on the website cause it was "easier". I can add the icons later in a separate PR if desired.

@@ -0,0 +1,185 @@
icons:
chasm:
use: ./chasm.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be cave?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, the commend is supposed to be for line 5

@Pistonight
Copy link
Contributor

I think some of the presets like caves and chasms can benefit from #30, where people (I) might want to have it in a movement config and also have an icon show up on the map, instead of having a line in the doc that says X cave.

I am fine with the presets. Please add icons as well otherwise the presets won't work

@savage13 savage13 merged commit ca554bc into main Sep 30, 2023
7 checks passed
@savage13 savage13 deleted the totk-presets-1 branch September 30, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants