Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export mist plugin #232

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Export mist plugin #232

merged 2 commits into from
Apr 1, 2024

Conversation

LtPeriwinkle
Copy link
Contributor

Mostly copy-pasted Livesplit plugin. Seems to work. Moved should_split_on func to native/mod.rs so both exporters can use it.

Pistonight
Pistonight reviewed Mar 30, 2024
View reviewed changes
Copy link
Contributor

@Pistonight Pistonight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor suggestions

docs/src/plugin/export-mist.md Outdated Show resolved Hide resolved
compiler-core/src/plugin/native/mod.rs Outdated Show resolved Hide resolved
@Pistonight
Copy link
Contributor

LGTM. Thanks for the PR

@Pistonight Pistonight merged commit 6642eae into Pistonite:main Apr 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pistonight Pistonight Pistonight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LtPeriwinkle @Pistonight