Add a checkmark for played matches #1547
Conversation
|
I can't really test that the changes work aesthetically when the match hasn't been played, since I couldn't find any events with matches that hadn't been played yet, but it looks good to me on both pages where the checkmark is present and where it isn't. |
There was a problem hiding this comment.
Something about me is slightly bothered that they don't quite line up vertically 😂. Not a big deal, feel free to fix if it's easy (maybe put it on the other side?), or leave it as is if it's not easy.
Also, here is an alternative color (same as the time text):
Not sure which I like better. The grey makes it a little more subtle compared to the match name, which I like. Either way is fine with me.
Feel free to merge without another review. Thanks for spending time on this PR!
|
I tried really hard to make the grid look the same across all the cards, and I just couldn't get it to work. I did the gray checkmarks. |
On the match cards for played matches on the event and event-team-matches pages, there is a checkmark between the name of the match and the timestamp. Ideally, the name appears close to the checkmark in all circumstances.
closes #1544