Feat: Allow using YouTube links in addition to video IDs #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements `getVideoId(youtubeUrl)`, which takes in a string containing a YouTube URL and tries to extract a video ID from it. This uses the querystring parser. If no querystring is found in the URL, it splits the URL's path by a '/' and checks if the last part of the URL is a valid YouTube ID. This handles URLs like 'https://youtu.be/id'. A function to check if a string is a valid HTTP or HTTPS URL has also been added for convenience.
Refactor updatePlayer() to handle YouTube video URLs in addition to IDs. Makes use of the previously implemented functions (see parent commit) to check if the string in the input field is a URL. For video IDs, an additional check has been put in place to somewhat validate the ID (just by checking its length for now). If the URL does not contain a video ID, or if the video ID is invalid, then the function returns to exit, and nothing is sent to the WebSocket server. However, errors are only logged, not shown to the user yet.
Update "Video ID" string to "Video URL or ID".
Add JSDoc to the new functions. Add some extra logging in these new functions.
Update some of the logging. Rename getVideoId() to extractVideoId().
Refactor some of the conditional logic to use early returns.
Phixyn
added
frontend client
|
Needs a little bit more testing. |
Also add some links to the URL API docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission
Thank you for taking the time to contribute to this project! Please take the time to tell us a bit about the changes you've made.
Description
Users are now able to submit YouTube links containing a video ID, to load a new video.
If an error occurs in extracting or using a video ID, users are not yet notified. This will be done as part of #38 and #75.
Closes #24.
Changes
updatePlayer()to check if the value of the input is a URL, and if so extract the ID from itBreaking Change?
Merging Checklist