make choices_queryset not dependent on the time range #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetrDlouhy
force-pushed
the
choice_queryset_quicker
branch
from
30773b6
to
af52009
Compare
PetrDlouhy
force-pushed
the
choice_queryset_quicker
branch
10 times, most recently
from
5ba2aaf
to
cf335fb
Compare
PetrDlouhy
force-pushed
the
choice_queryset_quicker
branch
from
cf335fb
to
d19c7cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way how to get all resulting values for given query is to run that query, which could be sometimes very expensive.
Much quicker way how to get those choices could be by just getting related values. Especially if there is few resulting values and big set of data.
Sometimes the chart will get very messy if there are all the choices visible even if they are 0.
So we either need to find a way how to only relevant values or we will need to make this as an optional feature.
Also it seems that there is issue in current workflow - count limit applies before the choices are reduced, so we can end up with just "other" option.