fix(lib): Catch and log TypeScriptImportException and exit with 1

PerfectlyNormal · Dec 5, 2023 · 7c5f3b9 · 7c5f3b9
1 parent 7185773
commit 7c5f3b9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [unreleased]
 
+### Fixed
+
+- Log an error and continue when we fail to convert a file
+
 ### Changed
 
 - Enable Dependabot version updates

diff --git a/TypeContractor/Contractor.cs b/TypeContractor/Contractor.cs
@@ -80,9 +80,17 @@ public int Build(MetadataLoadContext? metadataLoadContext = null, bool smartClea
                 .ToList();
 
             foreach (var type in outputTypes)
-            {
-                var filePath = writer.Write(type, outputTypes);
-                generatedFiles.Add(filePath);
+            {
+                try
+                {
+                    var filePath = writer.Write(type, outputTypes);
+                    generatedFiles.Add(filePath);
+                }
+                catch (TypeScriptImportException ex)
+                {
+                    _configuration.Logger.LogError(ex, $"Unable to generate typings for {type.Name} ({type.FullName})");
+                    returnCode = 1;
+                }
             }
         }