Update to SDK 0.46.14, ibc-go 6.2.0, latest gravity #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need to fix IBC middleware mocks
needs regenerated mocks for staking
EricBolten
requested review from
jackzampolin,
kkennis and
mvid
as code owners
cbrit
reviewed
Dec 12, 2023
| // baseapp.SetIAVLCacheSize(cast.ToInt(appOpts.Get(FlagIAVLCacheSize))), | ||
| // baseapp.SetIAVLDisableFastNode(cast.ToBool(appOpts.Get(FlagDisableIAVLFastNode))), | ||
| // baseapp.SetIAVLLazyLoading(cast.ToBool(appOpts.Get(FlagIAVLLazyLoading))), | ||
| baseappOptions := server.DefaultBaseappOptions(appOpts) |
There was a problem hiding this comment.
The only one I couldn't find (in this file) a mapping for was SetQueryGasLimit, which is in the new defaults, but other than that it seems correct to me.
zmanian
reviewed
Dec 12, 2023
Invalid legacy proposals do not seem to return a specific error code, but rather fail silently. For the initial invalid proposal test, we submit it and then query the gov module to see that no props have been created.
zmanian
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some things to note:
cmd/sommelier/cmd/root.gocould use a sanity check