Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v7 pre-Axelar #231

Merged
merged 6 commits into from
Nov 28, 2023
Merged

v7 pre-Axelar #231

merged 6 commits into from
Nov 28, 2023

Conversation

EricBolten
Copy link
Contributor

PR to prepare main for v7 prior to Axelar integration.

Includes:

  • Cleanly merge the 6.x-main line into current main in prep for v7
  • Implement v7 upgrade
  • Port steward-registry data to populate the initial state during the upgrade
  • Pubsub CLI
  • Move pubsub push URL from SubscriberIntent to Subscriber
  • Move signer checks in some pubsub messages to earlier in the flow if possible
  • Add exponent to auction token prices
  • Fix auction sale token price calculations to factor in exponent
  • Add minimum USD value for auctions
  • Correctly register auction TX command for bids
  • Update somm_proto

zmanian
zmanian reviewed Nov 16, 2023
View reviewed changes
app/upgrades/v7/upgrades.go
Exponent: 18,
LastUpdatedBlock: 1,
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should put a BTC and ETH price in the upgrade handler

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

zmanian
zmanian reviewed Nov 16, 2023
View reviewed changes
app/upgrades/v7/upgrades.go
"0x05641a27C82799AaF22b436F20A3110410f29652", // Steady MATIC
"0x6f069f711281618467dae7873541ecc082761b33", // Steady UNI
"0x97e6E0a40a3D02F12d1cEC30ebfbAE04e37C119E", // Real Yield USD
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to update this with all more recent cellars

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will have the handler fully up-to-date in an upcoming commit.

zmanian
zmanian approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@zmanian zmanian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issues I mentioned about having more values in the migration don't need to be addressed right now

@EricBolten EricBolten merged commit fd12f41 into main Nov 28, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmanian zmanian zmanian approved these changes

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@kkennis kkennis Awaiting requested review from kkennis

@mvid mvid Awaiting requested review from mvid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EricBolten @zmanian