Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Space Ruin: Voidhopper of Nexus #26809

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

haydenredacted
Copy link
Contributor

@haydenredacted haydenredacted commented Sep 17, 2024

What Does This PR Do

This PR adds a new space ruin called Voidhopper of Nexus (freighter.dmm). This ruin is a cargo ship with a variety of different items such as raw materials and mech equipment, it also comes with Russian Soviet Nians, a new simple mob that acts similar to the Russians you can find in space.

Why It's Good For The Game

More space ruins makes exploring space more fun.
Who said space Russians Soviets could only be human?

Images of changes

StrongDMM view:
image
Russian Soviet Nian:
image

Testing

Loaded up a server, found the ruin and all its loot. Killed the Russian Soviet Nians, the corpse with all the loot it should have dropped properly.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: Added a new space ruin, Voidhopper of Nexus
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Map Edit This PR will modify a map Configuration Change This PR changes the game configuration files. Please run via the host. Sprites This PR modifies the game sprites labels Sep 17, 2024
new         : _maps/map_files/RandomRuins/SpaceRuins/freighter.dmm
new         : code/modules/unit_tests/atmos/test_ventcrawl.dmm

Automatically commited by: tools\mapmerge2\fixup.py
@Fordoxia
Copy link
Contributor

I would expand the engine room for flavour.

Whilst asymmetrical ships are cool, the the centerline of the ship feels off. I'd lean harder into the asymmetry if you're going to employ it.

"XB" = (
/obj/structure/table,
/obj/item/paper{
info = "<h3>Voidhopper of Nexus Shipping Manifest</h3><hr><br>Order: #7934<br>Destination: <i> The destination seems to have been blacked out.</i><br>Requested By: Athena, Praetorian of Gliese<br>CONTENTS:<br><ul><li>1 pair of kitty ears</li><li>1 banhammer</li><li>1 exosuit mining scanner</li><li>1 diamond-tipped exosuit drill</li><li>1 "LittleBoy" Mining Grenade Launcher</li><li>1 mecha voice modification kit: Honk</li><li>20 plastitanium glass</li><li>50 uranium sheets</li><li>50 reinforced plasma glass</li><li>50 metal sheets</li><li>1 fuel tank</li><li>1 radiant dance machine mark IV</li><li>1 soap</li><li>1 advanced mop</li><li>1 advanced space cleaner</li></ul><br>CHECK CONTENTS AND SIGN BELOW THE LINE TO CONFIRM RECEIPT OF GOODS<hr><b>X: <i> Athena, Praetorian of Gliese </i> </b>";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a file /code/modules/away_missions/mission_code/ruins/nian_freighter.dm or similar and put this in there as a paper subtype:

/obj/item/paper/fluff/ruins/nian_freighter/manifest
	name = "Voidhopper of Nexus Shipping Manifest"
	info = {"
		<h3>Voidhopper of Nexus Shipping Manifest</h3>
		<hr />
		<br />Order: #7934<br />Destination:
		<i> The destination seems to have been blacked out.</i><br />Requested By:
		Athena, Praetorian of Gliese<br />CONTENTS:<br />
		<ul>
		  <li>1 pair of kitty ears</li>
		  <li>1 banhammer</li>
		  <li>1 exosuit mining scanner</li>
		  <li>1 diamond-tipped exosuit drill</li>
		  <li>1 "LittleBoy" Mining Grenade Launcher</li>
		  <li>1 mecha voice modification kit: Honk</li>
		  <li>20 plastitanium glass</li>
		  <li>50 uranium sheets</li>
		  <li>50 reinforced plasma glass</li>
		  <li>50 metal sheets</li>
		  <li>1 fuel tank</li>
		  <li>1 radiant dance machine mark IV</li>
		  <li>1 soap</li>
		  <li>1 advanced mop</li>
		  <li>1 advanced space cleaner</li>
		</ul>
		<br />CHECK CONTENTS AND SIGN BELOW THE LINE TO CONFIRM RECEIPT OF GOODS
		<hr />
		<b>X: <i> Athena, Praetorian of Gliese </i> </b>
	"}

See the similar ruin papers in code\modules\awaymissions\mission_code\ruins\deepstorage.dm as examples.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, could you check if I did what you said to do properly? Thanks!

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting approval This PR is waiting for approval internally Configuration Change This PR changes the game configuration files. Please run via the host. Map Edit This PR will modify a map Sprites This PR modifies the game sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants