Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paradise's soul removal part 7.25: firesuits, radsuits, workboots and all magboots #26671

Conversation

ElorgRHG
Copy link
Contributor

@ElorgRHG ElorgRHG commented Sep 2, 2024

Credits:
tgstation/tgstation#67000 for the incredible radsuit sprite that've been very slightly modified, the firesuit sprite and the workboots sprite.
and slight credit for the magboots from tgstation/tgstation#69134 but very heavily modified.

What Does This PR Do

Resprites the firesuit, the atmos firesuit and its hardhat, the radsuit and its radhood, workboots and all magboots.

Why It's Good For The Game

Slightly better sprites :).
However, I'll allow myself to break the PR template and put a single image of one of the resprited things here compared to what its replacing instead of just saying "soul bad" because it doesn't say much by itself and you, yes, you the person that's looking at this PR, can just see for yourself it this is good for the game. I'll say it is.
coughing baby vs nuclear bomb

Now moving on to actual images of changes.

Images of changes

I did not include every single species variant because every single species but skrell, nian, slime and plasmamen have their variants. That'd be a lot of screenshots.

Firesuit, atmos firesuit and radsuit:

1

Atmos firesuit's hardhat and radsuit's hood:

2

Magboots:

3

Work boots presented in Aseprite because I forgot to screenshot them in-game:

workboots

Testing

Arranged the Images of changes.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
imageadd: Resprited the firesuit, atmos firesuit and its hardhat, radsuit and its hood, workboots and all magboots.
/:cl:

@Contrabang
Copy link
Contributor

I like everything but the new CE magboots, the yellowish tint gave them character

@PopeDaveThe3th
Copy link
Contributor

Damn these look great. So long, old radsuit sprite, you will not be missed.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sprites This PR modifies the game sprites labels Sep 2, 2024
@AyIong
Copy link
Contributor

AyIong commented Sep 2, 2024

OH NOOO!!! MAH SOOOOL!!!!!

@BiancaWilkson BiancaWilkson added the Tweak This PR tweaks something ingame label Sep 3, 2024
Copy link
Contributor

@warriorstar-orion warriorstar-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you deleted the old sprites from their files? IDB doesn't show any deletions but it might just be having a moment

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Sep 3, 2024
@SynthTwo
Copy link
Contributor

SynthTwo commented Sep 3, 2024

!wiki_label

@github-actions github-actions bot added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Sep 3, 2024
@ElorgRHG
Copy link
Contributor Author

ElorgRHG commented Sep 3, 2024

Have you deleted the old sprites from their files? IDB doesn't show any deletions but it might just be having a moment

Forgot to delete them from their old locations yesterday but they are gone now.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Sep 4, 2024
Copy link
Contributor

@Christasmurf Christasmurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended, all icons in correct files, icons look good

@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Sep 11, 2024
@github-actions github-actions bot added Merge Conflict This PR is merge conflicted and removed Merge Conflict This PR is merge conflicted labels Sep 13, 2024
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Sep 14, 2024
Copy link
Contributor

@Christasmurf Christasmurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor edits for consistency with other items of similar nature/small cleanups

code/modules/clothing/head/hardhat.dm Outdated Show resolved Hide resolved
code/modules/clothing/suits/utility.dm Outdated Show resolved Hide resolved
code/modules/clothing/suits/utility.dm Show resolved Hide resolved
code/modules/clothing/suits/utility.dm Outdated Show resolved Hide resolved
@Burzah Burzah added this pull request to the merge queue Sep 23, 2024
Merged via the queue into ParadiseSS13:master with commit 55a8675 Sep 23, 2024
12 checks passed
@ElorgRHG ElorgRHG deleted the more-air-freshener-upon-engineering-related-stuff branch September 23, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Sprites This PR modifies the game sprites Tweak This PR tweaks something ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants