-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Lavaland tunnel themes. #26599
Open
warriorstar-orion
wants to merge
16
commits into
ParadiseSS13:master
Choose a base branch
from
warriorstar-orion:feat/lava/tunnels-redux-3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rework Lavaland tunnel themes. #26599
warriorstar-orion
wants to merge
16
commits into
ParadiseSS13:master
from
warriorstar-orion:feat/lava/tunnels-redux-3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadiseSS13-Bot
added
-Status: Awaiting type assignment
This PR is waiting for its type to be assigned internally
Map Edit
This PR will modify a map
labels
Aug 25, 2024
ParadiseSS13-Bot
added
-Status: Awaiting approval
This PR is waiting for approval internally
-Status: Awaiting review
This PR is awaiting review from the review team
and removed
-Status: Awaiting type assignment
This PR is waiting for its type to be assigned internally
-Status: Awaiting approval
This PR is waiting for approval internally
labels
Aug 26, 2024
CI is failing because of that runtime in river generation (which happens before caves). Should hopefully be fixed with #26606. |
ParadiseSS13-Bot
added
the
Testmerge Requested
This PR has a pending testmerge request
label
Aug 30, 2024
lewcc
reviewed
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me, though I'd like more eyes on it from lavaland-familiar folks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-Status: Awaiting review
This PR is awaiting review from the review team
Map Edit
This PR will modify a map
Testmerge Requested
This PR has a pending testmerge request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
This PR:
I tried to port the thematic elements of the cave themes as closely as possible.
Why It's Good For The Game
For players: The new caves look a lot better and more natural than the old algorithm.
For coders: The existing cave generator was tightly integrated into a specific /turf subtype which contained all its behavior, which 1) was unwieldy and overcomplicated as the cave generation grew more complex and 2) was one of the turf types generated during mineral generation, which would cause issues if trying to rework mineral generation in any way.
I believe using the rust functions will also be faster overall, though I didn't do any actual timing tests.
Images of changes
Classic Caves
Blocked Burrows
Deadly Deeprock
Testing
Generating lots and lots of maps.
Checking spawn rates for mobs/flora/megafauna in progress.
Declaration
Changelog
🆑
tweak: Lavaland cave tunnels are now a lot more organic and natural looking.
/:cl: