Skip to content

Commit

Permalink
🩹 [Patch]: Align code and process (#6)
Browse files Browse the repository at this point in the history
## Description

🩹 [Patch]: Align code and process

## Type of change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] 📖 [Docs]
- [ ] 🪲 [Fix]
- [x] 🩹 [Patch]
- [ ] ⚠️ [Security fix]
- [ ] 🚀 [Feature]
- [ ] 🌟 [Breaking change]

## Checklist

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
  • Loading branch information
MariusStorhaug authored Mar 29, 2024
1 parent dddfd5a commit 93e427c
Show file tree
Hide file tree
Showing 11 changed files with 132 additions and 152 deletions.
25 changes: 25 additions & 0 deletions .github/linters/.markdown-lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
###########################
## Markdown Linter rules ##
###########################

# Linter rules doc:
# - https://github.com/DavidAnson/markdownlint

###############
# Rules by id #
###############
MD004: false # Unordered list style
MD007:
indent: 2 # Unordered list indentation
MD013:
line_length: 808 # Line length
MD026:
punctuation: ".,;:!。,;:" # List of not allowed
MD029: false # Ordered list item prefix
MD033: false # Allow inline HTML
MD036: false # Emphasis used instead of a heading

#################
# Rules by tags #
#################
blank_lines: false # Error on blank lines
29 changes: 29 additions & 0 deletions .github/workflows/Linter.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Linter

run-name: "Linter - [${{ github.event.pull_request.title }} #${{ github.event.pull_request.number }}] by @${{ github.actor }}"

on: [pull_request]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

permissions:
contents: read
packages: read
statuses: write

jobs:
Lint:
name: Lint code base
runs-on: ubuntu-latest
steps:
- name: Checkout repo
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Lint code base
uses: super-linter/super-linter@latest
env:
GITHUB_TOKEN: ${{ github.token }}
4 changes: 3 additions & 1 deletion .github/workflows/Process-PSModule.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,13 @@ on:
- labeled

concurrency:
group: ${{ github.workflow }}
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

permissions:
contents: write
pull-requests: write
statuses: write

jobs:
Process-PSModule:
Expand Down
6 changes: 0 additions & 6 deletions .vscode/extensions.json

This file was deleted.

81 changes: 0 additions & 81 deletions .vscode/settings.json

This file was deleted.

2 changes: 1 addition & 1 deletion src/NerdFonts/public/Install-NerdFont.ps1
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#Requires -Modules Fonts
#Requires -Modules Utilities
#Requires -Modules Admin

function Install-NerdFont {
<#
Expand Down
11 changes: 0 additions & 11 deletions tests/Get-NerdFont.Tests.ps1

This file was deleted.

26 changes: 24 additions & 2 deletions tests/NerdFonts.Tests.ps1
Original file line number Diff line number Diff line change
@@ -1,11 +1,33 @@
Describe 'NerdFonts' {
[CmdletBinding()]
Param(
# Path to the module to test.
[Parameter()]
[string] $Path
)

Write-Verbose "Path to the module: [$Path]" -Verbose

Describe 'NerdFonts' {
Context 'Module' {
It 'The module should be available' {
Get-Module -Name 'NerdFonts' -ListAvailable | Should -Not -BeNullOrEmpty
Write-Verbose (Get-Module -Name 'NerdFonts' -ListAvailable | Out-String) -Verbose
}
It 'The module should be imported' {
{ Import-Module -Name 'NerdFonts' } | Should -Not -Throw
{ Import-Module -Name 'NerdFonts' -Verbose -RequiredVersion 999.0.0 -Force } | Should -Not -Throw
}
}

Context 'Get-NerdFont' {
It 'Function exists' {
Get-Command Get-NerdFont | Should -Not -BeNullOrEmpty
}

It 'Returns all fonts' {
$fonts = Get-NerdFont
Write-Verbose ($fonts | Out-String) -Verbose
$fonts | Should -Not -BeNullOrEmpty
}
}

}
12 changes: 6 additions & 6 deletions tmp/Download-NerdFonts.ps1
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
function Download-NerdFonts {
[CmdletBinding()]
param(
$Path = "$env:TEMP\NerdFonts"
)
# function Download-NerdFonts {
# [CmdletBinding()]
# param(
# $Path = "$env:TEMP\NerdFonts"
# )

}
# }
70 changes: 35 additions & 35 deletions tmp/Get-NerdFontsRelease.ps1
Original file line number Diff line number Diff line change
@@ -1,40 +1,40 @@
function Get-NerdFontsRelease {
[CmdletBinding()]
param(
[Parameter(
ParameterSetName = 'Latest',
Mandatory
)]
[switch] $Latest,
# function Get-NerdFontsRelease {
# [CmdletBinding()]
# param(
# [Parameter(
# ParameterSetName = 'Latest',
# Mandatory
# )]
# [switch] $Latest,

[Parameter(
ParameterSetName = 'Latest'
)]
[switch] $AllowPrerelease,
# [Parameter(
# ParameterSetName = 'Latest'
# )]
# [switch] $AllowPrerelease,

[Parameter(
ParameterSetName = 'Version'
)]
[ValidateSet({ Get-NerdFontsVersionList })]
[string] $Version
)
# [Parameter(
# ParameterSetName = 'Version'
# )]
# [ValidateSet({ Get-NerdFontsVersionList })]
# [string] $Version
# )

begin {
$versionPattern = [regex]'(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$'
}
# begin {
# $versionPattern = [regex]'(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$'
# }

process {
foreach ($TerraformPath in $Path) {
$terraformVersionOutput = & $TerraformPath --version
$version = $versionPattern.Match($terraformVersionOutput).Value
[pscustomobject]@{
Path = $TerraformPath
Version = $version
}
}
}
# process {
# foreach ($TerraformPath in $Path) {
# $terraformVersionOutput = & $TerraformPath --version
# $version = $versionPattern.Match($terraformVersionOutput).Value
# [pscustomobject]@{
# Path = $TerraformPath
# Version = $version
# }
# }
# }

end {
return $versions
}
}
# end {
# return $versions
# }
# }
18 changes: 9 additions & 9 deletions tmp/Get-NerdFontsVersionList.ps1
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
function Get-NerdFontsVersionList {
[OutputType([string[]])]
[CmdletBinding()]
param()
# function Get-NerdFontsVersionList {
# [OutputType([string[]])]
# [CmdletBinding()]
# param()

$versionPattern = [regex]'(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$'
# $versionPattern = [regex]'(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$'

$release = Invoke-RestMethod $script:NerdFontsReleaseURL -Verbose:$false
$versions = $release.tag_name | Where-Object { $_ -match $versionPattern } | Sort-Object
# $release = Invoke-RestMethod $script:NerdFontsReleaseURL -Verbose:$false
# $versions = $release.tag_name | Where-Object { $_ -match $versionPattern } | Sort-Object

return $versions
}
# return $versions
# }

0 comments on commit 93e427c

Please sign in to comment.