Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated "Other" #28

Merged
merged 19 commits into from
Mar 14, 2024
Merged

Updated "Other" #28

merged 19 commits into from
Mar 14, 2024

Conversation

MattsAttack
Copy link
Contributor

@MattsAttack MattsAttack commented Mar 14, 2024 •
edited by lishaduck
Loading

Description

This PR rewords and "fattens" all of the text in the other category and updates the section headings so that the "about other" page doesn't look as goofy.

I'm gonna work on the other sections later.

Type of Change

  • ✨ New feature
  • 🗑️ Chore

Checklist

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Fill out this template.
  • Log your hours.
  • Check that commits follow the Angular commit convention, more or less.
  • Ideally, include relevant tests that fail without this PR but pass with it (if applicable).

Tested on

  • macOS 14
  • Windows 10

@MattsAttack
Update section headings in so "about other" didn't look goofy
e2029e3 
Reworded and "fattened" all text in other
@lishaduck
Copy link
Member

Did you mean to close this?

@MattsAttack
Copy link
Contributor Author

Yes I'm gonna wait to merge until i finish rewriting the other sections. The other section looks 10x better now though

@lishaduck
Copy link
Member

For the future, you can mark a branch as a draft rather than closing it if it isn't ready.

@lishaduck lishaduck reopened this Mar 14, 2024
@lishaduck lishaduck marked this pull request as draft March 14, 2024 00:54
@lishaduck lishaduck added the enhancement New feature or request label Mar 14, 2024
@MattsAttack
Copy link
Contributor Author

cool beans

lishaduck
lishaduck reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@lishaduck lishaduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I left some quite a few review comments, but it's shaping up well. I think my only general feedback is just to think about commas and line wrapping.

I was wondering, are you customizing any of the sectionHeaders? I was trying to make it so that the headers on the index pages would be different to spice things up.

src/content/other/atomics.mdx Outdated Show resolved Hide resolved
src/content/other/appliances.mdx Outdated Show resolved Hide resolved
src/content/other/atomics.mdx Outdated Show resolved Hide resolved
src/content/other/billing.mdx Outdated Show resolved Hide resolved
src/content/other/billing.mdx Outdated Show resolved Hide resolved
src/content/other/utilities.mdx Outdated Show resolved Hide resolved
src/content/other/solar-lawn-lights.mdx Outdated Show resolved Hide resolved
src/content/other/wind.mdx Show resolved Hide resolved
src/content/other/wind.mdx Show resolved Hide resolved
src/content/other/wind.mdx Outdated Show resolved Hide resolved
@lishaduck lishaduck mentioned this pull request Mar 14, 2024
Merged
6 tasks
MattsAttack and others added 11 commits March 13, 2024 21:30
@MattsAttack
added alt text
ee79f6d
@MattsAttack
Updated recycling text and stuff through grammarly
18f7ba6
@MattsAttack
edited comment
f00299c
@MattsAttack @lishaduck
Update src/content/other/atomics.mdx
1d41184 
Co-authored-by: Eli <88557639+lishaduck@users.noreply.github.com>
Signed-off-by: Matthew Wasser <71449347+MattsAttack@users.noreply.github.com>
@MattsAttack @lishaduck
Update src/content/other/atomics.mdx
504ff9a 
Co-authored-by: Eli <88557639+lishaduck@users.noreply.github.com>
Signed-off-by: Matthew Wasser <71449347+MattsAttack@users.noreply.github.com>
@MattsAttack @lishaduck
Update src/content/other/appliances.mdx
8b9ca20 
Co-authored-by: Eli <88557639+lishaduck@users.noreply.github.com>
Signed-off-by: Matthew Wasser <71449347+MattsAttack@users.noreply.github.com>
@MattsAttack @lishaduck
Update src/content/other/billing.mdx
2ac2576 
Co-authored-by: Eli <88557639+lishaduck@users.noreply.github.com>
Signed-off-by: Matthew Wasser <71449347+MattsAttack@users.noreply.github.com>
@MattsAttack @lishaduck
Update src/content/other/solar-lawn-lights.mdx
676fb3e 
Co-authored-by: Eli <88557639+lishaduck@users.noreply.github.com>
Signed-off-by: Matthew Wasser <71449347+MattsAttack@users.noreply.github.com>
@MattsAttack @lishaduck
Update src/content/other/billing.mdx
2fd2390 
Co-authored-by: Eli <88557639+lishaduck@users.noreply.github.com>
Signed-off-by: Matthew Wasser <71449347+MattsAttack@users.noreply.github.com>
@MattsAttack @lishaduck
Update src/content/other/utilities.mdx
a9c4346 
Co-authored-by: Eli <88557639+lishaduck@users.noreply.github.com>
Signed-off-by: Matthew Wasser <71449347+MattsAttack@users.noreply.github.com>
@MattsAttack @lishaduck
Update src/content/other/wind.mdx
597f9ae 
Co-authored-by: Eli <88557639+lishaduck@users.noreply.github.com>
Signed-off-by: Matthew Wasser <71449347+MattsAttack@users.noreply.github.com>
@MattsAttack
Copy link
Contributor Author

I was wondering, are you customizing any of the sectionHeaders? I was trying to make it so that the headers on the index pages would be different to spice things up.

We could change them back but it felt kind of weird for the index page as you couldn't 100% tell what some of them were

@MattsAttack MattsAttack marked this pull request as ready for review March 14, 2024 14:20
@MattsAttack @lishaduck
Update src/content/other/electric-cars.mdx
7e95d1f 
Co-authored-by: Eli <88557639+lishaduck@users.noreply.github.com>
Signed-off-by: Matthew Wasser <71449347+MattsAttack@users.noreply.github.com>
@MattsAttack @lishaduck
Update src/content/other/hydroelectric.mdx
1a6dcbf 
Co-authored-by: Eli <88557639+lishaduck@users.noreply.github.com>
Signed-off-by: Matthew Wasser <71449347+MattsAttack@users.noreply.github.com>
@deno-deploy deno-deploy bot requested a deployment to Preview March 14, 2024 14:23 Abandoned
MattsAttack and others added 4 commits March 14, 2024 09:25
@MattsAttack @lishaduck
Update src/content/other/led-lights.mdx
4b73c44 
Co-authored-by: Eli <88557639+lishaduck@users.noreply.github.com>
Signed-off-by: Matthew Wasser <71449347+MattsAttack@users.noreply.github.com>
@MattsAttack @lishaduck
Update src/content/other/utilities.mdx
0027533 
Co-authored-by: Eli <88557639+lishaduck@users.noreply.github.com>
Signed-off-by: Matthew Wasser <71449347+MattsAttack@users.noreply.github.com>
@MattsAttack
changes nuclear file name
3784087
@MattsAttack
fix: the issues
780fd88
@MattsAttack
Copy link
Contributor Author

Idk what was up with that image bug earlier. I just checked again and all looks good. Gonna merge

@MattsAttack MattsAttack merged commit 48c78f6 into main Mar 14, 2024
5 checks passed
lishaduck
lishaduck approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@lishaduck lishaduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MattsAttack MattsAttack deleted the updated_text branch March 14, 2024 16:07
@lishaduck lishaduck added this to the State milestone Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lishaduck lishaduck lishaduck approved these changes

@iiAzui iiAzui Awaiting requested review from iiAzui iiAzui is a code owner

Assignees

@MattsAttack MattsAttack

Labels
enhancement New feature or request
Projects
None yet
Milestone
State
Development

Successfully merging this pull request may close these issues.
2 participants
@MattsAttack @lishaduck