Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New readings test data added #957

Merged
merged 5 commits into from
Jun 25, 2023

Conversation

dzheng13341
Copy link
Contributor

Description

3 test data from testing.md added to readings.js:

  • should have daily points for 15 minute reading intervals and quantity units with +-inf start/end time & kWh as BTU chained with reverse conversion
  • should have daily points for 15 minute reading intervals and raw units with +-inf start/end time & C as Widget with intercept & chained
  • should have daily points for 15 minute reading intervals and raw units with +-inf start/end time & C as Widget with intercept & chained & reverse conversions

Tests are successful.

Type of change

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request

Limitations

File testing.md should be updated if pull request is accepted.
For conversion c8 ['F', 'C', true, 0.555556, -17.77778, 'Fahrenheit → Celsius'], gave rounding errors so it is better to use
['F', 'C', true, 1/1.8, -32/1.8, 'Fahrenheit → Celsius'] for closer values.

dzheng13341 and others added 5 commits June 20, 2023 18:40
C to Widget normal conversion,
C to Widget reverse conversion.
This consistently uses the kWh units defined at the top.
It uses consistent formatting of array or arrays.
Updates comments where suggested changes to design document since those
were put into that document.
@huss
Copy link
Member

huss commented Jun 25, 2023

I updated the code for changes I thought we should use. This was not the result of the work by @dzheng13341 but what I noticed during the review of previous work.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @dzheng13341 for their first PR to OED. The work was very good and no issues were found. I have updated the testing design document to mark these three tests as complete.

@huss huss merged commit f987f68 into OpenEnergyDashboard:development Jun 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants