Default meter select #1348
Open
Default meter select #1348
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted should be shown as selected by default, without the user needing to click it.
…pplies to not only meter but also group
|
The code looks good, and very clear wit the functionality. it works and I'm personally not familiar with the nuances of react to determine if there is a better solution. |
|
Everything looks good to me. Please convert this draft to PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1186
Utilized React's useEffect hook to manage which option is selected when there is only one option (the only available choice, by default).
Type of change
Checklist
Limitations
None, at first the code was too specific and only applied to one of the data categories but after reanalysis it was rewritten to work in a more general sense.