Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 Bar Chart expected output files and testing cases #1027

Merged
merged 9 commits into from
Sep 30, 2023

Conversation

Jake-Bodin
Copy link
Contributor

Description

Title is self sufficient, Jake Bodin's first pull request,
Fixes #[issue] ???

(In general, OED likes to have at least one issue associated with each pull request. Replace [issue] with the OED GitHub issue number. In the preview you will see an issue description if you hover over that number. You can create one yourself before doing this pull request. This is where details are normally given on what is being addressed. Note you should not use the word "Fixes" if it does not completely address the issue since the issue would automatically be closed on merging the pull request. In that case use "Partly Addresses #[issue].)

Type of change

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])
???

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request ???
  • [ X] You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

(Describe any issues that remain or work that should still be done.)

@Jake-Bodin
Copy link
Contributor Author

The reason theirs so many calls is because I pushed to development when i meant to go to branch, it didn't matter but I wanted to fix and revert it, then I had some merge issues, not sure what they were, but everything should be good in the final merge to devolopment, that wont happen again.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @Jake-Bodin for doing this work and their first contribution to OED. The code is fine and works as expected. No changes are needed and it is ready to merge. Graduations on your first accepted work into OED.

@huss huss merged commit dd778b0 into OpenEnergyDashboard:development Sep 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants