Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention to examples folder #514

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Conversation

clausmichele
Copy link
Member

Fixes #513

@clausmichele clausmichele requested a review from m-mohr June 25, 2024 15:48
@clausmichele
Copy link
Member Author

@m-mohr can we merge this simple fix?

@m-mohr
Copy link
Member

m-mohr commented Jul 29, 2024

I think we had a PSC decision on this and I hadn't had the time yet to check what the actual outcome was.
I just want to update it directly in the right way, not merge yet another potentially wrong thing.

Edit: Just checked it, see below.

README.md Outdated
@@ -40,7 +40,7 @@ This repository contains a set of files formally describing the openEO Processes
## Process

* All new processes must be added to the [`proposals`](proposals/) folder.
* Processes will only be moved from proposals to the stable process specifications once there are at least two implementations and an example process in the [`examples`](examples/) folder showing it in a use case. This doesn't require a PSC vote individually as it's not a breaking change, just an addition.
* Processes will only be moved from proposals to the stable process specifications once there are at least two implementations. This doesn't require a PSC vote individually as it's not a breaking change, just an addition.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never explicitly discussed to remove this requirement (which we could discuss due to the fact that openeo-community-examples is pretty unmaintained), but we did discuss moving the examples:
Open-EO/PSC#14

So the correct way currently is to change as follows unless another PSC discussion takes place:

Suggested change
* Processes will only be moved from proposals to the stable process specifications once there are at least two implementations. This doesn't require a PSC vote individually as it's not a breaking change, just an addition.
* Processes will only be moved from proposals to the stable process specifications once there are at least two implementations and an example process in the [`openEO community examples`](https://github.com/Open-EO/openeo-community-examples/) showing it in a use case. This doesn't require a PSC vote individually as it's not a breaking change, just an addition.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, thanks for the feedback

@m-mohr m-mohr merged commit 6141771 into Open-EO:master Jul 29, 2024
1 check passed
@soxofaan
Copy link
Member

not sure if intended, but I noticed this PR was applied to master instead of going through draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guideline about new processes in README should be updated
3 participants