Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector to raster conversion #463

Open
wants to merge 6 commits into
base: draft
Choose a base branch
from

Conversation

JeroenVerstraelen
Copy link

Related issue: #442

@JeroenVerstraelen
Copy link
Author

The json should be valid but the automatic linter gives an error:

Unexpected token·in JSON at position 1639

@m-mohr
Copy link
Member

m-mohr commented Sep 12, 2023

You have to remove the spaces at the end of the return description.

@@ -0,0 +1,60 @@
{
"id": "vector_to_raster",
"description": "Creates a raster cube as output based on a vector cube. The values in the output raster cube are based on the numeric properties in the input vector cube.",
Copy link
Member

@m-mohr m-mohr Sep 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The values in the output raster cube are based on the numeric properties in the input vector cube.

What does this mean? Can this be explained a bit better/more precisely?

Generally, I think this needs more specific information about how the conversion is done to be testable in the future.

@m-mohr m-mohr added this to the 2.1.0 milestone Sep 30, 2023
Copy link
Member

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above.

JeroenVerstraelen and others added 4 commits May 13, 2024 13:42
Co-authored-by: Matthias Mohr <matthias@mohr.ws>
Co-authored-by: Matthias Mohr <matthias@mohr.ws>
Co-authored-by: Matthias Mohr <matthias@mohr.ws>
Co-authored-by: Matthias Mohr <matthias@mohr.ws>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants