Unlock request in PT using ocf_req_unlock() #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are situations when we can end up in engine_pt with cache lines locked for write. One example is engine_rd falling back to engine_pt after failure during cache line preparation, where write lock has been already taken. To handle this situation properly, unlock request using more general unlock function. Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
robertbaldyga
force-pushed
the
fix-req-unlock-pt
branch
from
3ed0e4d
to
d57c9bb
Compare
mmichal10
approved these changes
Sep 13, 2023
jfckm
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are situations when we can end up in engine_pt with cache lines locked for write. One example is engine_rd falling back to engine_pt after failure during cache line preparation, where write lock has been already taken. To handle this situation properly, unlock request using more general unlock function.