Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple derive macro for better struct support #138

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

rory-ocl
Copy link
Contributor

@rory-ocl rory-ocl commented Jul 30, 2024

Description

This allows usage of #[derive(AbiType)] within the sol! {} macro to support structs as return types. This should also apply to usage as parameters. I am curious about other use-cases such as structs defined outside of the sol! {} macro, and structs define in the sol_storage! {} macro.

Checklist

  • I have documented these changes where necessary.
  • I have read the DCO and ensured that these changes comply.
  • I assign this work under its open source licensing.

@rory-ocl rory-ocl changed the base branch from stylus to develop July 31, 2024 19:19
@rory-ocl rory-ocl marked this pull request as ready for review August 6, 2024 18:07
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rory-ocl rory-ocl merged commit e986088 into develop Aug 6, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants