Support for alloy_primitive int types #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
reviewed
Jul 25, 2024
| pub struct SolInt<const BITS: usize, const LIMBS: usize>; | ||
|
|
||
| impl<const BITS: usize, const LIMBS: usize> AbiType for Signed<BITS, LIMBS> | ||
| where |
There was a problem hiding this comment.
This is the most hardcore generic constraint I've seen 😅, great job on getting it to work
stylus-sdk/src/abi/ints.rs
Outdated
| let (head, _tail) = slice.split_at(TL); | ||
| let mut limbs = [0; TL]; | ||
| limbs.copy_from_slice(head); | ||
| /* TODO overflow check needed? |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
rauljordan
previously approved these changes
Jul 30, 2024
3 tasks
rory-ocl
force-pushed
the
int-return-types
branch
from
e710cd7
to
0116de8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for alloy_primitives::Signed and alloy_primitives::Uint in return types and parameters.
TODO
Still in draft as I finish up the following tasks:
Checklist