Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolidityError derives From<variant> #111

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Conversation

mikebenfield
Copy link

@mikebenfield mikebenfield commented Mar 6, 2024

Closes STY-26

@mikebenfield mikebenfield force-pushed the SolidityErrorFrom branch 2 times, most recently from 9da5770 to 6712dc6 Compare March 6, 2024 18:49
stylus-sdk/src/call/mod.rs Outdated Show resolved Hide resolved
stylus-sdk/src/call/error.rs Outdated Show resolved Hide resolved
Also allow stylus_sdk::call::Error in error variants
Copy link
Contributor

@rachel-bousfield rachel-bousfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Updated the example to include infallable methods

@rachel-bousfield rachel-bousfield merged commit 1918112 into stylus Mar 6, 2024
8 of 10 checks passed
@rachel-bousfield rachel-bousfield deleted the SolidityErrorFrom branch March 6, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants