Skip to content

Fixes for currently ongoing code audit #255

Fixes for currently ongoing code audit

Fixes for currently ongoing code audit #255

Triggered via pull request August 19, 2024 21:23
@rory-oclrory-ocl
synchronize #145
audit
Status Success
Total duration 42s
Artifacts

check.yml

on: pull_request
stable / fmt
5s
stable / fmt
Matrix: clippy
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
stable / fmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
stable / fmt
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
struct `StorageArray` has a public `len` method, but no `is_empty` method: stylus-sdk/src/storage/array.rs#L42
warning: struct `StorageArray` has a public `len` method, but no `is_empty` method --> stylus-sdk/src/storage/array.rs:42:5 | 42 | pub const fn len(&self) -> usize { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty = note: `#[warn(clippy::len_without_is_empty)]` on by default
doc list item missing indentation: stylus-sdk/src/lib.rs#L13
warning: doc list item missing indentation --> stylus-sdk/src/lib.rs:13:5 | 13 | //! storage caching. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 13 | //! storage caching. | ++
stable / clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
stable / clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
struct `StorageArray` has a public `len` method, but no `is_empty` method: stylus-sdk/src/storage/array.rs#L42
warning: struct `StorageArray` has a public `len` method, but no `is_empty` method --> stylus-sdk/src/storage/array.rs:42:5 | 42 | pub const fn len(&self) -> usize { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty = note: `#[warn(clippy::len_without_is_empty)]` on by default
doc list item without indentation: stylus-sdk/src/lib.rs#L13
warning: doc list item without indentation --> stylus-sdk/src/lib.rs:13:5 | 13 | //! storage caching. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 13 | //! storage caching. | ++
beta / clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
beta / clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/